added support for parsing compressed qtraces #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code uses archive.h to support reading compressed files. It is based off the old archive support code from before the merging of qtdis into qtreader. I wasn't sure the best way to handle determining whether to read compressed vs. uncompressed so I left that up to the user and added: qtreader_initialize_fd_compressed qtreader_next_record_compressed and assumed the user would call the correct one. Perhaps qtreader_next_record_compressed could be removed, but I wasn't sure how to automatically determine if the qtrace file was compressed and the initialization of the compressed qtreader_state is a bit different. I also added a test5.c that compares an uncompressed (arg1) qtrace to a compressed (arg2) qtrace and ensures that the lengths and records from each are the same. I ran it on a couple qtraces with bz2 compression and it worked. Signed-off-by: Nick Orzol <[email protected]>
nrorzol
force-pushed
the
archive_support
branch
from
edff073 to
2ed43d4
Compare
|
I wasn't sure if there is a debug flag that should be used somewhere for the debug print statements I found helpful, so I left them commented out. I also wasn't sure about adding the archive dependency and if it would be desirable to have a flag to enable/disable the feature in compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code uses archive.h to support reading compressed files. It is based off the old archive support code from before the merging of
qtdisintoqtreader.I wasn't sure the best way to handle determining whether to read compressed vs. uncompressed so I left that up to the user and added:
qtreader_initialize_fd_compressedqtreader_next_record_compressedand assumed the user would call the correct one. Perhaps
qtreader_next_record_compressedcould be removed, but I wasn't sure how to automatically determine if the qtrace file was compressed and the initialization of the compressedqtreader_stateis a bit different.I also added a
test5.cthat compares an uncompressed (arg1) qtrace to a compressed (arg2) qtrace and ensures that the lengths and records from each are the same. I ran it on a couple qtraces with bz2 compression and it worked.